From: Phil Sutter <phil@nwl.cc>
To: "Štěpán Němec" <snemec@redhat.com>
Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH nft] tests: cover baecd1cf2685 ("segtree: Fix segfault when restoring a huge interval set")
Date: Wed, 20 Oct 2021 15:53:38 +0200 [thread overview]
Message-ID: <20211020135338.GI1668@orbyte.nwl.cc> (raw)
In-Reply-To: <20211020153801+0200.908737-snemec@redhat.com>
On Wed, Oct 20, 2021 at 03:38:01PM +0200, Štěpán Němec wrote:
> On Wed, 20 Oct 2021 15:13:54 +0200
> Phil Sutter wrote:
>
> > Thanks for the patch, just one remark:
> >
> > [...]
> >> +cat >>"$ruleset_file" <<\EOF
> > ~~~
> > Is this backslash a typo or intentional?
>
> It instructs the shell not to perform expansion on the heredoc lines
> (which would include interpreting '$big_set' as a shell variable).
Ah, I missed the part about quoting parts of 'word'. :)
Patch applied, thanks!
Cheers, Phil
prev parent reply other threads:[~2021-10-20 13:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 12:42 [PATCH nft] tests: cover baecd1cf2685 ("segtree: Fix segfault when restoring a huge interval set") Štěpán Němec
2021-10-20 13:13 ` Phil Sutter
2021-10-20 13:38 ` Štěpán Němec
2021-10-20 13:53 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020135338.GI1668@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=snemec@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).