netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: "Štěpán Němec" <snemec@redhat.com>
Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH nft] tests: run-tests.sh: ensure non-zero exit when $failed != 0
Date: Wed, 20 Oct 2021 17:06:41 +0200	[thread overview]
Message-ID: <20211020150641.GK1668@orbyte.nwl.cc> (raw)
In-Reply-To: <20211020124409.489875-1-snemec@redhat.com>

Hi,

On Wed, Oct 20, 2021 at 02:44:09PM +0200, Štěpán Němec wrote:
> POSIX [1] does not specify the behavior of `exit' with arguments
> outside the 0-255 range, but what generally (bash, dash, zsh, OpenBSD
> ksh, busybox) seems to happen is the shell exiting with status & 255
> [2], which results in zero exit for certain non-zero arguments.

Standards aside, failed=256 is an actual bug:

| % bash -c "exit 255"; echo $?
| 255
| % bash -c "exit 256"; echo $?
| 0
| % bash -c "exit 257"; echo $?
| 1

Thanks, Phil

  reply	other threads:[~2021-10-20 15:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 12:44 [PATCH nft] tests: run-tests.sh: ensure non-zero exit when $failed != 0 Štěpán Němec
2021-10-20 15:06 ` Phil Sutter [this message]
2021-10-27  9:09   ` Pablo Neira Ayuso
2021-11-02 20:31     ` Phil Sutter
2021-11-02 20:44       ` Pablo Neira Ayuso
2021-11-02 21:01         ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211020150641.GK1668@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=snemec@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).