Re: [PATCH nft 1/3] tests: shell: README: copy edit

["Štěpán Němec" <snemec@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]

On Wed, 20 Oct 2021 17:04:02 +0200
Phil Sutter wrote:

> What you you mean with 'copy edit'?

https://en.wikipedia.org/wiki/Copy_editing

> Please make subject line a bit more comprehensible.

Would "fix language issues" work for you? Or, could we perhaps keep the
original subject, and add "fix language issues" in the body, to address
your other concern?

> Also, adding at least a single line of description is mandatory, even
> if the subject speaks for itself.

Commit messages consisting of only the subject and trailers (SOB et al.)
are quite common, both in this project and elsewhere. [1]

I suppose that as someone responsible for reviewing and applying
patches, you're free to install any hoops you see fit for contributors
to jump through, but if it is the project's and contributors' best
interest you have in mind, I think it would be better if you mentioned
the "description is always mandatory" rule explicitly in patch
submission guidelines [2] (providing a rationale and being consistent
about it in reality would be better still).

Thanks,
 
  Štěpán

[1] To get some picture, you can pipe output of the attached script to
'git log --stdin --no-walk', or further pipe that to 'git shortlog -ns'
for a summary.

[2] https://wiki.nftables.org/wiki-nftables/index.php/Portal:DeveloperDocs/Patch_submission_guidelines


[-- Attachment #2: git_log_filter.perl --]
[-- Type: text/plain, Size: 334 bytes --]

#!/usr/bin/env perl

use strict;
use warnings;

my $log_cmd = "git log -z --pretty=format:'%H\n%b'";

local $/ = "\0";

open(my $log_fh, '-|', $log_cmd) or die "Can't start git log: $!";

while (<$log_fh>) {
  chomp;
  my ($hash, $body) = split(/\n/, $_, 2);
  print($hash, "\n") if ($body =~ /\A\s*(?:[^:\n]+: +[^\n]+\n?)*\s*\Z/);
}