From: Jeremy Sowden <jeremy@azazel.net>
To: Netfilter Devel <netfilter-devel@vger.kernel.org>
Subject: [ulogd2 PATCH 00/26] Compiler Warning Fixes
Date: Sat, 30 Oct 2021 17:44:06 +0100 [thread overview]
Message-ID: <20211030164432.1140896-1-jeremy@azazel.net> (raw)
Patch 1 adds the `format` GCC attribute to ulogd_log.
Patches 2-5 fix the format errors revealed by the patch 1.
Patches 6-8 fix fall-through warnings.
Patches 9-10 are flow-control improvements related to patch 8.
Patch 11 replaces malloc+memset with calloc.
Patches 12-14 fix string-truncation warnings.
Patch 15 fixes a possible unaligned pointer access.
Patch 16 fixes DBI deprecation warnings.
Patches 17-20 fix more truncation warnings.
Patch 21 adds error-checking to sqlite SQL preparation.
Patches 22-26 fix more truncation and format warnings.
Jeremy Sowden (26):
include: add format attribute to __ulogd_log declaration
ulog: remove empty log-line
ulog: fix order of log arguments
ulog: correct log specifiers
output: IPFIX: correct format-specifiers.
jhash: add "fall through" comments to switch cases.
db: add missing `break` to switch-case.
filter: HWHDR: replace `switch` with `if`.
filter: HWHDR: re-order KEY_RAW_MAC checks.
filter: HWHDR: remove zero-initialization of MAC type.
Replace malloc+memset with calloc
filter: PWSNIFF: replace malloc+strncpy with strndup.
input: UNIXSOCK: stat socket-path first before creating the socket.
input: UNIXSOCK: fix possible truncation of socket path
input: UNIXSOCK: prevent unaligned pointer access.
output: DBI: fix deprecation warnings.
output: DBI: fix string truncation warnings
output: MYSQL: Fix string truncation warning
output: PGSQL: Fix string truncation warning
output: SQLITE3: Fix string truncation warnings and possible buffer
overruns.
output: SQLITE3: catch errors creating SQL statement
util: db: fix possible string truncation.
output: JSON: fix output of GMT offset.
output: JSON: fix printf truncation warnings.
output: JSON: optimize appending of newline to output.
output: JSON: fix possible truncation of socket path
filter/ulogd_filter_HWHDR.c | 54 +++++++++++-------------
filter/ulogd_filter_PWSNIFF.c | 26 ++++++------
include/ulogd/jhash.h | 24 +++++------
include/ulogd/ulogd.h | 3 +-
input/packet/ulogd_inppkt_UNIXSOCK.c | 55 +++++++++++++-----------
output/dbi/ulogd_output_DBI.c | 60 ++++++++++++---------------
output/ipfix/ipfix.c | 4 +-
output/ipfix/ulogd_output_IPFIX.c | 7 ++--
output/mysql/ulogd_output_MYSQL.c | 19 ++++-----
output/pgsql/ulogd_output_PGSQL.c | 19 ++++-----
output/sqlite3/ulogd_output_SQLITE3.c | 58 +++++++++++++-------------
output/ulogd_output_JSON.c | 42 ++++++++++---------
src/ulogd.c | 6 +--
util/db.c | 24 +++++------
14 files changed, 192 insertions(+), 209 deletions(-)
--
2.33.0
next reply other threads:[~2021-10-30 16:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 16:44 Jeremy Sowden [this message]
2021-10-30 16:44 ` [ulogd2 PATCH 01/26] include: add format attribute to __ulogd_log declaration Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 02/26] ulog: remove empty log-line Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 03/26] ulog: fix order of log arguments Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 04/26] ulog: correct log specifiers Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 05/26] output: IPFIX: correct format-specifiers Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 06/26] jhash: add "fall through" comments to switch cases Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 07/26] db: add missing `break` to switch-case Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 08/26] filter: HWHDR: replace `switch` with `if` Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 09/26] filter: HWHDR: re-order KEY_RAW_MAC checks Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 10/26] filter: HWHDR: remove zero-initialization of MAC type Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 11/26] Replace malloc+memset with calloc Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 12/26] filter: PWSNIFF: replace malloc+strncpy with strndup Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 13/26] input: UNIXSOCK: stat socket-path first before creating the socket Jeremy Sowden
2021-10-30 17:33 ` Jan Engelhardt
2021-11-06 13:51 ` Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 14/26] input: UNIXSOCK: fix possible truncation of socket path Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 15/26] input: UNIXSOCK: prevent unaligned pointer access Jeremy Sowden
2021-10-30 17:42 ` Jan Engelhardt
2021-11-06 14:13 ` Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 16/26] output: DBI: fix deprecation warnings Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 17/26] output: DBI: fix string truncation warnings Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 18/26] output: MYSQL: Fix string truncation warning Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 19/26] output: PGSQL: " Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 20/26] output: SQLITE3: Fix string truncation warnings and possible buffer overruns Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 21/26] output: SQLITE3: catch errors creating SQL statement Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 22/26] util: db: fix possible string truncation Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 23/26] output: JSON: fix output of GMT offset Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 24/26] output: JSON: fix printf truncation warnings Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 25/26] output: JSON: optimize appending of newline to output Jeremy Sowden
2021-10-30 16:44 ` [ulogd2 PATCH 26/26] output: JSON: fix possible truncation of socket path Jeremy Sowden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211030164432.1140896-1-jeremy@azazel.net \
--to=jeremy@azazel.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).