netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Štěpán Němec" <snemec@redhat.com>
To: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Cc: phil@nwl.cc
Subject: [PATCH nft v2 3/4] tests: shell: README: clarify test file name convention
Date: Fri,  5 Nov 2021 12:39:10 +0100	[thread overview]
Message-ID: <20211105113911.153006-3-snemec@redhat.com> (raw)
In-Reply-To: <20211105113911.153006-1-snemec@redhat.com>

Since commit 4d26b6dd3c4c, test file name suffix no longer reflects
expected exit code in all cases.

Move the sentence "Since they are located with `find', test files can
be put in any subdirectory." to a separate paragraph.

Fixes: 4d26b6dd3c4c ("tests: shell: change all test scripts to return 0")
Signed-off-by: Štěpán Němec <snemec@redhat.com>
---
 tests/shell/README | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/shell/README b/tests/shell/README
index 4dd595d99556..ea2b0b98f95f 100644
--- a/tests/shell/README
+++ b/tests/shell/README
@@ -10,8 +10,11 @@ To run the test suite (as root):
  # ./run-tests.sh
 
 Test files are executable files matching the pattern <<name_N>>,
-where N is the expected return code of the executable. Since they
-are located with `find', test files can be put in any subdirectory.
+where N should be 0 in all new tests. All tests should return 0 on
+success.
+
+Since they are located with `find', test files can be put in any
+subdirectory.
 
 You can turn on a verbose execution by calling:
  # ./run-tests.sh -v
-- 
2.33.1


  parent reply	other threads:[~2021-11-05 11:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 12:45 [PATCH nft 1/3] tests: shell: README: copy edit Štěpán Němec
2021-10-20 12:45 ` [PATCH nft 2/3] tests: shell: README: $NFT does not have to be a path to a binary Štěpán Němec
2021-10-20 12:45 ` [PATCH nft 3/3] tests: shell: README: clarify test file name convention Štěpán Němec
2021-10-20 15:04 ` [PATCH nft 1/3] tests: shell: README: copy edit Phil Sutter
2021-10-21  8:30   ` Štěpán Němec
2021-10-21 10:26     ` Phil Sutter
2021-10-21 11:03       ` Štěpán Němec
2021-10-27  9:06         ` Pablo Neira Ayuso
2021-10-27  9:51           ` Štěpán Němec
2021-10-27 10:13             ` Pablo Neira Ayuso
2021-10-27 11:04               ` Štěpán Němec
2021-10-27 19:07                 ` Pablo Neira Ayuso
2021-11-05 11:39                   ` [PATCH nft v2 1/4] " Štěpán Němec
2021-11-05 11:39                     ` [PATCH nft v2 2/4] tests: shell: README: $NFT does not have to be a path to a binary Štěpán Němec
2021-11-05 11:39                     ` Štěpán Němec [this message]
2021-11-05 11:39                     ` [PATCH nft v2 4/4] tests: shell: $NFT needs to be invoked unquoted Štěpán Němec
2021-11-05 13:22                     ` [PATCH nft v2 1/4] tests: shell: README: copy edit Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211105113911.153006-3-snemec@redhat.com \
    --to=snemec@redhat.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).