From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: [libnftnl PATCH 3/7] set: Introduce NFTNL_SET_DESC_CONCAT_DATA
Date: Wed, 24 Nov 2021 18:22:38 +0100 [thread overview]
Message-ID: <20211124172242.11402-4-phil@nwl.cc> (raw)
In-Reply-To: <20211124172242.11402-1-phil@nwl.cc>
Analogous to NFTNL_SET_DESC_CONCAT, introduce a data structure
describing individual data lengths of elements' concatenated data
fields.
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
include/libnftnl/set.h | 1 +
include/set.h | 2 ++
src/set.c | 8 ++++++++
3 files changed, 11 insertions(+)
diff --git a/include/libnftnl/set.h b/include/libnftnl/set.h
index 1ffb6c415260d..958bbc9065f67 100644
--- a/include/libnftnl/set.h
+++ b/include/libnftnl/set.h
@@ -33,6 +33,7 @@ enum nftnl_set_attr {
NFTNL_SET_EXPR,
NFTNL_SET_EXPRESSIONS,
NFTNL_SET_DESC_BYTEORDER,
+ NFTNL_SET_DESC_CONCAT_DATA,
__NFTNL_SET_MAX
};
#define NFTNL_SET_MAX (__NFTNL_SET_MAX - 1)
diff --git a/include/set.h b/include/set.h
index 816bd24faf651..a9f6225401a4e 100644
--- a/include/set.h
+++ b/include/set.h
@@ -28,6 +28,8 @@ struct nftnl_set {
uint32_t byteorder;
uint8_t field_len[NFT_REG32_COUNT];
uint8_t field_count;
+ uint8_t data_len[NFT_REG32_COUNT];
+ uint8_t data_count;
} desc;
struct list_head element_list;
diff --git a/src/set.c b/src/set.c
index 651eaf5503dee..e793282175eb5 100644
--- a/src/set.c
+++ b/src/set.c
@@ -100,6 +100,7 @@ void nftnl_set_unset(struct nftnl_set *s, uint16_t attr)
case NFTNL_SET_TIMEOUT:
case NFTNL_SET_GC_INTERVAL:
case NFTNL_SET_DESC_BYTEORDER:
+ case NFTNL_SET_DESC_CONCAT_DATA:
break;
case NFTNL_SET_USERDATA:
xfree(s->user.data);
@@ -221,6 +222,10 @@ int nftnl_set_set_data(struct nftnl_set *s, uint16_t attr, const void *data,
case NFTNL_SET_DESC_BYTEORDER:
s->desc.byteorder = *(uint32_t *)data;
break;
+ case NFTNL_SET_DESC_CONCAT_DATA:
+ memcpy(&s->desc.data_len, data, data_len);
+ while (s->desc.data_len[++s->desc.data_count]);
+ break;
}
s->flags |= (1 << attr);
return 0;
@@ -318,6 +323,9 @@ const void *nftnl_set_get_data(const struct nftnl_set *s, uint16_t attr,
case NFTNL_SET_DESC_BYTEORDER:
*data_len = sizeof(uint32_t);
return &s->desc.byteorder;
+ case NFTNL_SET_DESC_CONCAT_DATA:
+ *data_len = s->desc.data_count;
+ return s->desc.data_len;
}
return NULL;
}
--
2.33.0
next prev parent reply other threads:[~2021-11-24 17:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 17:22 [libnftnl PATCH 0/7] Stabilize debug output on different endian systems Phil Sutter
2021-11-24 17:22 ` [libnftnl PATCH v2 1/7] src: add infrastructure to infer byteorder from keys Phil Sutter
2021-12-12 17:12 ` Jeremy Sowden
2021-11-24 17:22 ` [libnftnl PATCH 2/7] set: Introduce NFTNL_SET_DESC_BYTEORDER Phil Sutter
2021-11-24 17:22 ` Phil Sutter [this message]
2021-11-30 13:46 ` [libnftnl PATCH 3/7] set: Introduce NFTNL_SET_DESC_CONCAT_DATA Pablo Neira Ayuso
2021-11-30 17:45 ` Phil Sutter
2022-01-05 16:17 ` Pablo Neira Ayuso
2022-01-06 13:10 ` Phil Sutter
2022-01-20 0:08 ` Pablo Neira Ayuso
2021-11-24 17:22 ` [libnftnl PATCH 4/7] data_reg: Support varying byteorder in concat data Phil Sutter
2021-11-24 17:22 ` [libnftnl PATCH 5/7] data_reg: Respect each value's size Phil Sutter
2021-11-24 17:22 ` [libnftnl PATCH 6/7] include: Introduce and publish struct nftnl_set_desc Phil Sutter
2021-11-24 17:22 ` [libnftnl PATCH 7/7] set: Introduce nftnl_set_elem_snprintf_desc() Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211124172242.11402-4-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).