From: Florian Westphal <fw@strlen.de>
To: Pham Thanh Tuyen <phamtyn@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: PROBLEM: Injected conntrack lost helper
Date: Tue, 1 Feb 2022 15:14:43 +0100 [thread overview]
Message-ID: <20220201141443.GC18351@breakpoint.cc> (raw)
In-Reply-To: <bca957db-0774-e337-fc3a-ada0c4325fe9@gmail.com>
Pham Thanh Tuyen <phamtyn@gmail.com> wrote:
> Previously I also thought ct->status |= IPS_HELPER; is ok, but after
> internal pointer assigning with RCU_INIT_POINTER() need external pointer
> assigning with rcu_assign_pointer() in __nf_ct_try_assign_helper() function.
I'm not following.
__nf_ct_try_assign_helper() doesn't do anything once that flag is set,
so how could the helper get lost later?
next prev parent reply other threads:[~2022-02-01 14:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f9fb5616-0b37-d76b-74e5-53751d473432@gmail.com>
[not found] ` <3f416429-b1be-b51a-c4ef-6274def33258@iogearbox.net>
[not found] ` <0f4edf58-7b4e-05e8-3f13-d34819b8d5db@gmail.com>
2022-01-31 11:20 ` PROBLEM: Injected conntrack lost helper Florian Westphal
2022-01-31 13:47 ` Pham Thanh Tuyen
2022-01-31 13:55 ` Pham Thanh Tuyen
2022-02-01 3:08 ` Pham Thanh Tuyen
2022-02-01 10:29 ` Pablo Neira Ayuso
2022-02-01 12:04 ` Florian Westphal
2022-02-01 13:32 ` Pham Thanh Tuyen
2022-02-01 14:14 ` Florian Westphal [this message]
2022-02-02 1:43 ` Pham Thanh Tuyen
2022-02-02 11:48 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201141443.GC18351@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phamtyn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).