From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: [iptables PATCH 0/2] Improve error messages for unsupported extensions
Date: Fri, 11 Feb 2022 18:12:09 +0100 [thread overview]
Message-ID: <20220211171211.26484-1-phil@nwl.cc> (raw)
Failure to load an extension leads to iptables cmdline parser
complaining about any extension options instead of the extension itself.
This is at least misleading.
This series eliminates the odd error message and instead adds a warning
if a requested extension is not available at all in kernel.
Things are a bit complicated due to the fact that newer kernels not
necessarily support revision 0 of all extensions. So change iptables
first to only register revision 0 if no higher one was accepted earlier.
This allows for a "not even revision 0 is supported" logic.
Phil Sutter (2):
libxtables: Register only the highest revision extension
Improve error messages for unsupported extensions
iptables/nft.c | 12 +++++++++---
libxtables/xtables.c | 17 ++++++++++++++---
2 files changed, 23 insertions(+), 6 deletions(-)
--
2.34.1
next reply other threads:[~2022-02-11 17:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 17:12 Phil Sutter [this message]
2022-02-11 17:12 ` [iptables PATCH 1/2] libxtables: Register only the highest revision extension Phil Sutter
2022-02-11 17:12 ` [iptables PATCH 2/2] Improve error messages for unsupported extensions Phil Sutter
2022-03-02 14:52 ` [iptables PATCH 0/2] " Phil Sutter
2022-03-02 15:06 ` Florian Westphal
2022-03-02 20:17 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220211171211.26484-1-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).