From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6845DC433F5 for ; Tue, 15 Feb 2022 15:36:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240757AbiBOPgl (ORCPT ); Tue, 15 Feb 2022 10:36:41 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:41098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240651AbiBOPf2 (ORCPT ); Tue, 15 Feb 2022 10:35:28 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58646C1C9D; Tue, 15 Feb 2022 07:31:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ADDA9B81A9A; Tue, 15 Feb 2022 15:31:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F903C340F2; Tue, 15 Feb 2022 15:31:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644939072; bh=OjeT7xbUg1MBVFOFUc1x+gta//Ub/1+0ZP9aLZZxhhc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BmtEPydHNyILagPR/KQaNExbyP6KVF77vYnApXBAYpy+QjqqEpKOWLpgOAbu2X2sy Mbd4r7ETqSDAjZz9N4MM0oFLacv/OEw4JZMstoTu6P0jrKbFpBw1762XviV5HAmoKB OAU12d1bC4Qp8MxQR5A5kyjE6So6i3/tQ9ZVBsFyPyyfnQ9mDEW7Va3zrv/Ecyyfsg hSapRfSXH18u4Y2HWSt6lSdBRADjQSDPGYzKagB4lVYHnSAO59yQk7BQbYYtwyioxl IN6h2KsczxK5LKZ7GB2z8NsDA6qgu2WRP4WBukaILLHU3g3GDTZPbe/89yhUVcALXt DEYZ8tOzBKzAA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Florian Westphal , Vivek Thrivikraman , Pablo Neira Ayuso , Sasha Levin , kadlec@netfilter.org, davem@davemloft.net, kuba@kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 04/11] netfilter: conntrack: don't refresh sctp entries in closed state Date: Tue, 15 Feb 2022 10:30:57 -0500 Message-Id: <20220215153104.581786-4-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220215153104.581786-1-sashal@kernel.org> References: <20220215153104.581786-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org From: Florian Westphal [ Upstream commit 77b337196a9d87f3d6bb9b07c0436ecafbffda1e ] Vivek Thrivikraman reported: An SCTP server application which is accessed continuously by client application. When the session disconnects the client retries to establish a connection. After restart of SCTP server application the session is not established because of stale conntrack entry with connection state CLOSED as below. (removing this entry manually established new connection): sctp 9 CLOSED src=10.141.189.233 [..] [ASSURED] Just skip timeout update of closed entries, we don't want them to stay around forever. Reported-and-tested-by: Vivek Thrivikraman Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1579 Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/nf_conntrack_proto_sctp.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/nf_conntrack_proto_sctp.c index a937d4f75613f..8cb62805fd684 100644 --- a/net/netfilter/nf_conntrack_proto_sctp.c +++ b/net/netfilter/nf_conntrack_proto_sctp.c @@ -394,6 +394,15 @@ static int sctp_packet(struct nf_conn *ct, pr_debug("Setting vtag %x for dir %d\n", ih->init_tag, !dir); ct->proto.sctp.vtag[!dir] = ih->init_tag; + + /* don't renew timeout on init retransmit so + * port reuse by client or NAT middlebox cannot + * keep entry alive indefinitely (incl. nat info). + */ + if (new_state == SCTP_CONNTRACK_CLOSED && + old_state == SCTP_CONNTRACK_CLOSED && + nf_ct_is_confirmed(ct)) + ignore = true; } ct->proto.sctp.state = new_state; -- 2.34.1