From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org
Subject: Re: [nf-next PATCH] netfilter: conntrack: Relax helper auto-assignment warning for nftables
Date: Sat, 19 Feb 2022 14:25:47 +0100 [thread overview]
Message-ID: <20220219132547.GA27537@breakpoint.cc> (raw)
In-Reply-To: <20220219132024.29328-1-phil@nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> With nftables, no template is being used and instead helper assignment
> happens after conntrack initialization. With helper auto assignment
> being disabled by default, this leads to this spurious kernel log
> suggesting to use iptables CT target.
>
> To avoid the bogus and confusing message, check helper's refcount: It is
> initialized to 1 by nf_conntrack_helper_register() and incremented by
> nf_conntrack_helper_try_module_get() during nft_ct_helper_obj_init(). So
> if its value is larger than 1, it must be in use *somewhere*.
Why not set cnet->auto_assign_helper_warned = true; from nft_ct.c?
next prev parent reply other threads:[~2022-02-19 13:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-19 13:20 [nf-next PATCH] netfilter: conntrack: Relax helper auto-assignment warning for nftables Phil Sutter
2022-02-19 13:25 ` Florian Westphal [this message]
2022-02-19 13:32 ` Phil Sutter
2022-02-19 13:41 ` Florian Westphal
2022-02-19 14:02 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220219132547.GA27537@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).