From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 304CBC433EF for ; Sun, 27 Feb 2022 18:07:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230085AbiB0SHs (ORCPT ); Sun, 27 Feb 2022 13:07:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbiB0SHs (ORCPT ); Sun, 27 Feb 2022 13:07:48 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B2D157160; Sun, 27 Feb 2022 10:07:11 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1nONwp-0005rE-8e; Sun, 27 Feb 2022 19:07:07 +0100 Date: Sun, 27 Feb 2022 19:07:07 +0100 From: Florian Westphal To: Eric Dumazet Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , netfilter-devel@vger.kernel.org, netdev , Eric Dumazet , syzbot Subject: Re: [PATCH nf] netfilter: fix use-after-free in __nf_register_net_hook() Message-ID: <20220227180707.GA8536@breakpoint.cc> References: <20220227180141.931857-1-eric.dumazet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220227180141.931857-1-eric.dumazet@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Eric Dumazet wrote: > We must not dereference @new_hooks after nf_hook_mutex has been released, > because other threads might have freed our allocated hooks already. Oh, right you are. Acked-by: Florian Westphal