From: Florian Westphal <fw@strlen.de>
To: Tom Rix <trix@redhat.com>
Cc: Florian Westphal <fw@strlen.de>,
pablo@netfilter.org, kadlec@netfilter.org, davem@davemloft.net,
kuba@kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfilter: conditionally use ct and ctinfo
Date: Mon, 7 Mar 2022 22:54:12 +0100 [thread overview]
Message-ID: <20220307215412.GA1822@breakpoint.cc> (raw)
In-Reply-To: <b795685f-6cdb-5493-8280-75749ddb0f6f@redhat.com>
Tom Rix <trix@redhat.com> wrote:
>
> On 3/7/22 4:46 AM, Florian Westphal wrote:
> > trix@redhat.com <trix@redhat.com> wrote:
> > > From: Tom Rix <trix@redhat.com>
> > >
> > > The setting ct and ctinfo are controlled by
> > > CONF_NF_CONNTRACK. So their use should also
> > > be controlled.
> > Any reason for this change?
>
> Define and use are connected. Doing something to one without doing something
> to the other doesn't make sense.
We often rely on compiler to remove branches that always evaluate to
false, just like in this case.
> Could removing the CONF_NF_CONNTRACK be done for the define side ?
Doubt it. Looking at git history it avoids build breakage.
prev parent reply other threads:[~2022-03-07 21:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-05 18:08 [PATCH] netfilter: conditionally use ct and ctinfo trix
2022-03-07 12:46 ` Florian Westphal
2022-03-07 13:39 ` Tom Rix
2022-03-07 21:54 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220307215412.GA1822@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).