From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7920FC433EF for ; Mon, 7 Mar 2022 21:54:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242901AbiCGVzQ (ORCPT ); Mon, 7 Mar 2022 16:55:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243959AbiCGVzO (ORCPT ); Mon, 7 Mar 2022 16:55:14 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E00227E0A8; Mon, 7 Mar 2022 13:54:18 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1nRLIy-0000vI-P4; Mon, 07 Mar 2022 22:54:12 +0100 Date: Mon, 7 Mar 2022 22:54:12 +0100 From: Florian Westphal To: Tom Rix Cc: Florian Westphal , pablo@netfilter.org, kadlec@netfilter.org, davem@davemloft.net, kuba@kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: conditionally use ct and ctinfo Message-ID: <20220307215412.GA1822@breakpoint.cc> References: <20220305180853.696640-1-trix@redhat.com> <20220307124652.GB21350@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Tom Rix wrote: > > On 3/7/22 4:46 AM, Florian Westphal wrote: > > trix@redhat.com wrote: > > > From: Tom Rix > > > > > > The setting ct and ctinfo are controlled by > > > CONF_NF_CONNTRACK. So their use should also > > > be controlled. > > Any reason for this change? > > Define and use are connected. Doing something to one without doing something > to the other doesn't make sense. We often rely on compiler to remove branches that always evaluate to false, just like in this case. > Could removing the CONF_NF_CONNTRACK be done for the define side ? Doubt it. Looking at git history it avoids build breakage.