From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf,v2 2/2] netfilter: nf_tables: initialize registers in nft_do_chain()
Date: Thu, 17 Mar 2022 14:18:13 +0100 [thread overview]
Message-ID: <20220317131813.GD9722@breakpoint.cc> (raw)
In-Reply-To: <20220317130734.97839-2-pablo@netfilter.org>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> Initialize registers to avoid stack leak into userspace.
>
> Fixes: 22fe54d5fefc ("netfilter: nf_tables: add support for dynamic set updates")
As per David, my assessment was incorrect, this needs to be
Fixes: 96518518cc41 ("netfilter: add nftables")
... because its possible to exfiltrate via cmp+imm and observe if there
is a match (accept/drop/counter, etc).
Patch is correct though, please consider pushing this out with updates
fixes tag.
Thanks!
next prev parent reply other threads:[~2022-03-17 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 13:07 [PATCH nf,v2 1/2] netfilter: nf_tables: validate registers coming from userspace Pablo Neira Ayuso
2022-03-17 13:07 ` [PATCH nf,v2 2/2] netfilter: nf_tables: initialize registers in nft_do_chain() Pablo Neira Ayuso
2022-03-17 13:18 ` Florian Westphal [this message]
2022-03-17 13:13 ` [PATCH nf,v2 1/2] netfilter: nf_tables: validate registers coming from userspace Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220317131813.GD9722@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).