From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52D27C433F5 for ; Fri, 18 Mar 2022 15:17:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237892AbiCRPS3 (ORCPT ); Fri, 18 Mar 2022 11:18:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236012AbiCRPS2 (ORCPT ); Fri, 18 Mar 2022 11:18:28 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 260E947574 for ; Fri, 18 Mar 2022 08:17:10 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1nVELg-00048U-Sz; Fri, 18 Mar 2022 16:17:04 +0100 Date: Fri, 18 Mar 2022 16:17:04 +0100 From: Florian Westphal To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org, fw@strlen.de Subject: Re: [PATCH nf-next] netfilter: nf_conntrack_tcp: skip tracking for offloaded packets Message-ID: <20220318151704.GG9722@breakpoint.cc> References: <20220318144939.69465-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220318144939.69465-1-pablo@netfilter.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Pablo Neira Ayuso wrote: > Sometimes flowtable datapath passes up packets to classic forwarding > path, eg. mtu exceeded case. Skip TCP tracking otherwise these packets > are considered invalid by conntrack. They are? nft_flow_offload_eval() sets IP_CT_TCP_FLAG_BE_LIBERAL for the conntrack, so at least window checks are disabled.