* [PATCH] ebtables: fix the 'static' build target
@ 2022-03-18 22:58 Robert Kolchmeyer
0 siblings, 0 replies; only message in thread
From: Robert Kolchmeyer @ 2022-03-18 22:58 UTC (permalink / raw)
To: netfilter-devel; +Cc: Robert Kolchmeyer
Currently, `make static` results in the following error:
undefined reference to `main'
I took a guess at what 'static' is supposed to produce, and thought it
would make sense to use the main definition from ebtables-standalone.c.
Also, producing 'static' by linking against a libebtc.a results in a
non-functional program (immediate segmentation fault). This is because
the initialization functions defined in libebtc.a aren't linked into
the result program. I ran into issues trying to use the --whole-archive
linker option with libtool, so I figured linking in the libebtc object
files directly was the simplest approach.
Signed-off-by: Robert Kolchmeyer <rkolchmeyer@google.com>
---
Makefile.am | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 6181003..b246064 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -50,9 +50,8 @@ ebtables_legacy_LDADD = libebtc.la
ebtablesd_LDADD = libebtc.la
ebtables_legacy_restore_SOURCES = ebtables-restore.c
ebtables_legacy_restore_LDADD = libebtc.la
-static_SOURCES = ebtables.c
+static_SOURCES = ebtables-standalone.c $(libebtc_la_SOURCES)
static_LDFLAGS = -static
-static_LDADD = libebtc.la
examples_ulog_test_ulog_SOURCES = examples/ulog/test_ulog.c getethertype.c
daemon: ebtablesd ebtablesu
--
2.35.1.894.gb6a874cedc-goog
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-03-18 22:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-18 22:58 [PATCH] ebtables: fix the 'static' build target Robert Kolchmeyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).