From: Florian Westphal <fw@strlen.de>
To: Jakob Koschel <jakobkoschel@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Mike Rapoport <rppt@kernel.org>,
Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
Cristiano Giuffrida <c.giuffrida@vu.nl>,
"Bos, H.J." <h.j.bos@vu.nl>
Subject: Re: [PATCH] netfilter: nf_tables: replace unnecessary use of list_for_each_entry_continue()
Date: Sun, 20 Mar 2022 01:44:29 +0100 [thread overview]
Message-ID: <20220320004429.GD13956@breakpoint.cc> (raw)
In-Reply-To: <20220319202526.2527974-1-jakobkoschel@gmail.com>
Jakob Koschel <jakobkoschel@gmail.com> wrote:
> Since there is no way for the previous list_for_each_entry() to exit
> early, this call to list_for_each_entry_continue() is always guaranteed
> to start with the first element of the list and can therefore be
> replaced with a call to list_for_each_entry().
>
> In preparation to limit the scope of the list iterator to the list
> traversal loop, the list iterator variable 'rule' should not be used
> past the loop.
>
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
>
> - list_for_each_entry_continue(rule, &chain->rules, list) {
> + list_for_each_entry(rule, &chain->rules, list) {
> if (!nft_is_active_next(net, rule))
> continue;
You could also replace the first entry_continue and get rid of the
preceeding
rule = list_entry().
prev parent reply other threads:[~2022-03-20 0:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 20:25 [PATCH] netfilter: nf_tables: replace unnecessary use of list_for_each_entry_continue() Jakob Koschel
2022-03-20 0:44 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220320004429.GD13956@breakpoint.cc \
--to=fw@strlen.de \
--cc=bjohannesmeyer@gmail.com \
--cc=c.giuffrida@vu.nl \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=h.j.bos@vu.nl \
--cc=jakobkoschel@gmail.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).