From: Florian Westphal <fw@strlen.de>
To: Jakob Koschel <jakobkoschel@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2] netfilter: nf_tables: replace unnecessary use of list_for_each_entry_continue()
Date: Tue, 22 Mar 2022 12:30:05 +0100 [thread overview]
Message-ID: <20220322113005.GE24574@breakpoint.cc> (raw)
In-Reply-To: <20220322105645.3667322-1-jakobkoschel@gmail.com>
Jakob Koschel <jakobkoschel@gmail.com> wrote:
[ trimmed CC ]
> Since there is no way for list_for_each_entry_continue() to start
> interating in the middle of the list they can be replaced with a call
> to list_for_each_entry().
>
> In preparation to limit the scope of the list iterator to the list
> traversal loop, the list iterator variable 'rule' should not be used
> past the loop.
Reviewed-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2022-03-22 11:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 10:56 [PATCH v2] netfilter: nf_tables: replace unnecessary use of list_for_each_entry_continue() Jakob Koschel
2022-03-22 11:30 ` Florian Westphal [this message]
2022-04-05 10:36 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220322113005.GE24574@breakpoint.cc \
--to=fw@strlen.de \
--cc=jakobkoschel@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).