* [iptables PATCH] xlate-test: Fix for empty source line on failure
@ 2022-03-30 15:59 Phil Sutter
0 siblings, 0 replies; only message in thread
From: Phil Sutter @ 2022-03-30 15:59 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: netfilter-devel
The code overwrites 'line' before checking expected output. Save it in a
temporary variable.
Fixes: 62828a6aff231 ("tests: xlate-test: support multiline expectation")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
xlate-test.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/xlate-test.py b/xlate-test.py
index d78e864869318..03bef7e2e5934 100755
--- a/xlate-test.py
+++ b/xlate-test.py
@@ -42,6 +42,7 @@ def run_test(name, payload):
line = payload.readline()
while line:
if line.startswith(keywords):
+ sourceline = line
tests += 1
process = Popen([ xtables_nft_multi ] + shlex.split(line), stdout=PIPE, stderr=PIPE)
(output, error) = process.communicate()
@@ -58,7 +59,7 @@ def run_test(name, payload):
test_passed = False
failed += 1
result.append(name + ": " + red("Fail"))
- result.append(magenta("src: ") + line.rstrip(" \n"))
+ result.append(magenta("src: ") + sourceline.rstrip(" \n"))
result.append(magenta("exp: ") + expected)
result.append(magenta("res: ") + translation + "\n")
else:
--
2.34.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-03-30 16:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-30 15:59 [iptables PATCH] xlate-test: Fix for empty source line on failure Phil Sutter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).