From: Florian Westphal <fw@strlen.de>
To: Jeremy Sowden <jeremy@azazel.net>
Cc: Florian Westphal <fw@strlen.de>,
Netfilter Devel <netfilter-devel@vger.kernel.org>
Subject: Re: [nf-next PATCH v2 1/5] netfilter: bitwise: keep track of bit-length of expressions
Date: Sat, 9 Apr 2022 11:58:02 +0200 [thread overview]
Message-ID: <20220409095802.GC19371@breakpoint.cc> (raw)
In-Reply-To: <YlFUBZg+983PofgH@azazel.net>
Jeremy Sowden <jeremy@azazel.net> wrote:
> Good point. I imagine I copied and pasted the types from `len`, which
> also has `NLA_U32` and `u8`. It, however, is parsed correctly:
>
> err = nft_parse_u32_check(tb[NFTA_BITWISE_LEN], U8_MAX, &len);
> if (err < 0)
> return err;
>
> Since `len` is `u8`, `nbits` will need to be `u16`. My inclination is
> to leave the netlink type as NLA_U32 and parse it as follows:
>
> err = nft_parse_u32_check(tb[NFTA_BITWISE_NBITS], U8_MAX * BITS_PER_BYTE,
> &nbits);
> if (err < 0)
> return err;
Yes, thats fine as well.
next prev parent reply other threads:[~2022-04-09 9:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 12:04 [nf-next PATCH v2 0/5] netfilter: bitwise: support boolean operations with variable RHS operands Jeremy Sowden
2022-04-04 12:04 ` [nf-next PATCH v2 1/5] netfilter: bitwise: keep track of bit-length of expressions Jeremy Sowden
2022-04-05 11:28 ` Florian Westphal
2022-04-05 20:47 ` Jeremy Sowden
2022-04-06 3:12 ` Florian Westphal
2022-05-05 19:54 ` Jeremy Sowden
2022-04-08 23:27 ` Florian Westphal
2022-04-09 9:38 ` Jeremy Sowden
2022-04-09 9:58 ` Florian Westphal [this message]
2022-04-04 12:04 ` [nf-next PATCH v2 2/5] netfilter: bitwise: replace hard-coded size with `sizeof` expression Jeremy Sowden
2022-04-09 10:07 ` Florian Westphal
2022-04-04 12:04 ` [nf-next PATCH v2 3/5] netfilter: bitwise: improve error goto labels Jeremy Sowden
2022-04-09 10:07 ` Florian Westphal
2022-04-04 12:04 ` [nf-next PATCH v2 4/5] netfilter: bitwise: rename some boolean operation functions Jeremy Sowden
2022-04-04 12:04 ` [nf-next PATCH v2 5/5] netfilter: bitwise: add support for doing AND, OR and XOR directly Jeremy Sowden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220409095802.GC19371@breakpoint.cc \
--to=fw@strlen.de \
--cc=jeremy@azazel.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).