From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next RFC 2/2] netfilter: conntrack: skip event delivery for the netns exit path
Date: Sun, 10 Apr 2022 17:38:31 +0200 [thread overview]
Message-ID: <20220410153831.GD5623@breakpoint.cc> (raw)
In-Reply-To: <YlL2Vfn3ijjh9O97@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > If you really dislike the nfnl changes I will respin without this
> > and will keep the pernet ctnetlink callback.
>
> OK, my patch is not covering all the possible cases then.
>
> Probably we can remove the hooks from .pre_exit, then force a run of
> the garbage collector from there. Then .exit path skips event delivery
> as my patch does.
Hmm, sounds tricky, but doabble.
> This would allow to remove the per-netns callback workaround, and all
> would be handled from nf_conntrack instead?
Ok. I will drop the pernet change from this patch set.
prev parent reply other threads:[~2022-04-10 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 12:58 [PATCH nf-next RFC 1/2] netfilter: conntrack: add nf_ct_iter_data object for nf_ct_iterate_cleanup*() Pablo Neira Ayuso
2022-04-08 12:58 ` [PATCH nf-next RFC 2/2] netfilter: conntrack: skip event delivery for the netns exit path Pablo Neira Ayuso
2022-04-08 19:34 ` Florian Westphal
2022-04-10 15:23 ` Pablo Neira Ayuso
2022-04-10 15:38 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220410153831.GD5623@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).