From: Stefano Brivio <sbrivio@redhat.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nft_set_rbtree: overlap detection with element re-addition after deletion
Date: Thu, 21 Apr 2022 16:06:17 +0200 [thread overview]
Message-ID: <20220421160617.487260d4@elisabeth> (raw)
In-Reply-To: <20220418102105.826027-1-pablo@netfilter.org>
Hi Pablo,
On Mon, 18 Apr 2022 12:21:05 +0200
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> This patch fixes spurious EEXIST errors.
>
> Extend d2df92e98a34 ("netfilter: nft_set_rbtree: handle element
> re-addition after deletion") to deal with elements with same end flags
> in the same transation.
>
> Reset the overlap flag as described by 7c84d41416d8 ("netfilter:
> nft_set_rbtree: Detect partial overlaps on insertion").
>
> Fixes: 7c84d41416d8 ("netfilter: nft_set_rbtree: Detect partial overlaps on insertion")
> Fixes: d2df92e98a34 ("netfilter: nft_set_rbtree: handle element re-addition after deletion")
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Sorry for the delay, and thanks for fixing this. I believe this is
correct, but I haven't tested it.
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
prev parent reply other threads:[~2022-04-21 14:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 10:21 [PATCH nf] netfilter: nft_set_rbtree: overlap detection with element re-addition after deletion Pablo Neira Ayuso
2022-04-21 14:06 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421160617.487260d4@elisabeth \
--to=sbrivio@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).