From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] src: fix always-true assertions
Date: Tue, 26 Apr 2022 13:22:44 +0200 [thread overview]
Message-ID: <20220426112244.GA9849@breakpoint.cc> (raw)
In-Reply-To: <YmfNP3VBYN5F2vJ3@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Tue, Apr 26, 2022 at 12:29:35PM +0200, Florian Westphal wrote:
> > assert(1) is a no-op, this should be assert(0). Use BUG() instead.
> > Add missing CATCHALL to avoid BUG().
>
> LGTM.
>
> So this is fixing a bug with catch-all element, correct?
Not really, the default label is hit, assert(1) does not do anything.
After making the assertion work we need to avoid the 'default' label.
prev parent reply other threads:[~2022-04-26 11:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 10:29 [PATCH nft] src: fix always-true assertions Florian Westphal
2022-04-26 10:45 ` Pablo Neira Ayuso
2022-04-26 11:22 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220426112244.GA9849@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).