From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F19C433EF for ; Thu, 16 Jun 2022 13:46:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377227AbiFPNq2 (ORCPT ); Thu, 16 Jun 2022 09:46:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376284AbiFPNq2 (ORCPT ); Thu, 16 Jun 2022 09:46:28 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 94B0C37A09 for ; Thu, 16 Jun 2022 06:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655387186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FmNUkOO/CPYlAiNCXkHb5y6oDWLQMyJAjm4NQJecMuc=; b=WFALmw9GM4+CyIOfeMgeaF/dJ9GlRfm2f9YlsqWOmc5dWrU1NY31f2LINs4WBKQbnDNalz A6WacI27vys4uLQ1quAuntrGK2n3Y2iyGjAk88iljgnYpQVPnpJlCgOTfVN9rKhSSNDkR0 n1l28Yf8PZF2/TzKoHp0m619+92Kibg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-595-h1PLAn-NMViEKO72XyHw_w-1; Thu, 16 Jun 2022 09:46:23 -0400 X-MC-Unique: h1PLAn-NMViEKO72XyHw_w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 728793C138A1; Thu, 16 Jun 2022 13:46:22 +0000 (UTC) Received: from maya.cloud.tilaa.com (unknown [10.40.208.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 27A712026D2D; Thu, 16 Jun 2022 13:46:22 +0000 (UTC) Date: Thu, 16 Jun 2022 15:46:18 +0200 From: Stefano Brivio To: Jie2x Zhou Cc: Pablo Neira Ayuso , shuah@kernel.org, liuhangbin@gmail.com, fw@strlen.de, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Philip Li , kernel test robot , netfilter-devel@vger.kernel.org Subject: Re: [PATCH] selftests: netfilter: correct PKTGEN_SCRIPT_PATHS in nft_concat_range.sh Message-ID: <20220616154618.0eb6b283@elisabeth> In-Reply-To: References: <20220616074046.49349-1-jie2x.zhou@intel.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hi Jie2x, On Thu, 16 Jun 2022 11:53:41 +0200 Pablo Neira Ayuso wrote: > Cc'ing netfilter-devel and Stefano Brivio. > > On Thu, Jun 16, 2022 at 03:40:46PM +0800, Jie2x Zhou wrote: > > Before change: > > make -C netfilter > > TEST: performance > > net,port [SKIP] > > perf not supported > > port,net [SKIP] > > perf not supported > > net6,port [SKIP] > > perf not supported > > port,proto [SKIP] > > perf not supported > > net6,port,mac [SKIP] > > perf not supported > > net6,port,mac,proto [SKIP] > > perf not supported > > net,mac [SKIP] > > perf not supported > > > > After change: > > net,mac [ OK ] > > baseline (drop from netdev hook): 2061098pps > > baseline hash (non-ranged entries): 1606741pps > > baseline rbtree (match on first field only): 1191607pps > > set with 1000 full, ranged entries: 1639119pps > > ok 8 selftests: netfilter: nft_concat_range.sh > > > > Fixes: 611973c1e06f ("selftests: netfilter: Introduce tests for sets with range concatenation") > > Reported-by: kernel test robot > > Signed-off-by: Jie2x Zhou > > --- > > tools/testing/selftests/netfilter/nft_concat_range.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/netfilter/nft_concat_range.sh b/tools/testing/selftests/netfilter/nft_concat_range.sh > > index b35010cc7f6a..a6991877e50c 100755 > > --- a/tools/testing/selftests/netfilter/nft_concat_range.sh > > +++ b/tools/testing/selftests/netfilter/nft_concat_range.sh > > @@ -31,7 +31,7 @@ BUGS="flush_remove_add reload" > > > > # List of possible paths to pktgen script from kernel tree for performance tests > > PKTGEN_SCRIPT_PATHS=" > > - ../../../samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh > > + ../../../../samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh This came from the fact that I used, for testing, to copy the directories 'samples' and 'selftests' to the root of a filesystem on a virtual machine, instead of copying the full 'tools' directory. It was a very arbitrary usage though, also given that 'selftests' is typically biggest directory in 'tools', so there's no need to keep the previous path. Thanks for fixing this, Reviewed-by: Stefano Brivio -- Stefano