From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: Florian Westphal <fw@strlen.de>
Subject: [PATCH nf 0/2] netfilter: fix two nf_dup bugs with egress hook
Date: Mon, 20 Jun 2022 16:17:29 +0200 [thread overview]
Message-ID: <20220620141731.7362-1-fw@strlen.de> (raw)
We need to be more careful now that nf_dup is exposed to new
egress hook.
When called from egress hook, we need to skip push of mac header,
this is only ok for ingress invocation.
Also add a recursion counter to prevent re-entry into the expression.
Florian Westphal (2):
netfilter: nf_dup_netdev: do not push mac header a second time
netfilter: nf_dup_netdev: add and use recursion counter
net/netfilter/nf_dup_netdev.c | 25 +++++++++++++++++++++----
1 file changed, 21 insertions(+), 4 deletions(-)
--
2.35.1
next reply other threads:[~2022-06-20 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 14:17 Florian Westphal [this message]
2022-06-20 14:17 ` [PATCH nf 1/2] netfilter: nf_dup_netdev: do not push mac header a second time Florian Westphal
2022-06-20 14:17 ` [PATCH nf 2/2] netfilter: nf_dup_netdev: add and use recursion counter Florian Westphal
2022-06-21 8:48 ` [PATCH nf 0/2] netfilter: fix two nf_dup bugs with egress hook Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620141731.7362-1-fw@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).