From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
Jan Engelhardt <jengelh@inai.de>,
Erik Skultety <eskultet@redhat.com>,
netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] iptables: xshared: Ouptut '--' in the opt field in ipv6's fake mode
Date: Sat, 23 Jul 2022 14:35:45 +0200 [thread overview]
Message-ID: <20220723123545.GA20457@breakpoint.cc> (raw)
In-Reply-To: <YtvDzOxd1/eEMaFo@orbyte.nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> Another bug I found while playing around is this:
>
> | # iptables -A FORWARD -p icmpv6
> | # iptables -vnL FORWARD
> | Chain FORWARD (policy ACCEPT 0 packets, 0 bytes)
> | pkts bytes target prot opt in out source destination
> | 0 0 ipv6-icmp-- * * 0.0.0.0/0 0.0.0.0/0
>
> print_rule_details() does not append a space after the protocol name if it is
> longer or equal to five characters.
>
> Both bugs seem to exist since day 1, I'm still tempted to fix them, i.e.:
>
> - Print protocol numbers with --numeric
> - Adjust the protocol format string from "%-5s" to "%-4s " for protocol
> names and from "%-5hu" to "%-4hu " for protocol numbers to force a
> single white space
>
> Objections anyone?
No, go ahead. Also, I think that the proposed "--" change is the least
intrusive option so I'm inclined to apply the patch as-is.
next prev parent reply other threads:[~2022-07-23 12:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 13:06 [iptables PATCH] iptables: xshared: Ouptut '--' in the opt field in ipv6's fake mode Erik Skultety
2022-07-20 14:20 ` Florian Westphal
2022-07-20 16:11 ` Erik Skultety
2022-07-23 9:47 ` Phil Sutter
2022-07-23 12:35 ` Florian Westphal [this message]
2022-07-20 16:07 ` Jan Engelhardt
2022-07-20 16:56 ` Erik Skultety
2022-07-21 7:22 ` Jan Engelhardt
2022-07-25 21:39 ` Florian Westphal
2022-07-26 6:55 ` Erik Skultety
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220723123545.GA20457@breakpoint.cc \
--to=fw@strlen.de \
--cc=eskultet@redhat.com \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).