From: "wenxu@chinatelecom.cn" <wenxu@chinatelecom.cn>
To: "Pablo Neira Ayuso" <pablo@netfilter.org>
Cc: netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: Re: [PATCH nf-next v2 1/3] nf_flow_table_offload: offload the vlan encap in the flowtable
Date: Tue, 2 Aug 2022 12:40:00 +0800 [thread overview]
Message-ID: <2022080212395929523424@chinatelecom.cn> (raw)
In-Reply-To: Yuerh8IrTVa35dIs@salvia
>> +static void nf_flow_encap_push(struct sk_buff *skb,
>> + struct flow_offload_tuple_rhash *tuplehash)
>> +{
>> + int i;
>> +
>> + for (i = 0; i < tuplehash->tuple.encap_num; i++) {
>> + switch (tuplehash->tuple.encap[i].proto) {
>> + case htons(ETH_P_8021Q):
>> + case htons(ETH_P_8021AD):
>> + skb_vlan_push(skb,
>
>Nit: skb_vlan_push() might fail.
>
The packet maybe modified. So maybe only drop this packet if skb_vlan_push failed?
prev parent reply other threads:[~2022-08-02 4:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 6:57 [PATCH nf-next v2 1/3] nf_flow_table_offload: offload the vlan encap in the flowtable wenxu
2022-05-26 6:57 ` [PATCH nf-next v2 2/3] nf_flow_table_offload: offload the PPPoE " wenxu
2022-08-01 10:37 ` Pablo Neira Ayuso
2022-08-02 4:43 ` wenxu
2022-05-26 6:57 ` [PATCH nf-next v2 3/3] selftests: netfilter: flowtable vlan filtering bridge support wenxu
2022-08-01 10:31 ` [PATCH nf-next v2 1/3] nf_flow_table_offload: offload the vlan encap in the flowtable Pablo Neira Ayuso
2022-08-02 3:41 ` wenxu
2022-08-02 4:40 ` wenxu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2022080212395929523424@chinatelecom.cn \
--to=wenxu@chinatelecom.cn \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).