From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31C23ECAAD8 for ; Wed, 21 Sep 2022 20:27:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230408AbiIUU1E (ORCPT ); Wed, 21 Sep 2022 16:27:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229804AbiIUU1D (ORCPT ); Wed, 21 Sep 2022 16:27:03 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC8A3792EE for ; Wed, 21 Sep 2022 13:27:01 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1ob6J9-0001HQ-4x; Wed, 21 Sep 2022 22:26:59 +0200 Date: Wed, 21 Sep 2022 22:26:59 +0200 From: Florian Westphal To: Jeremy Sowden Cc: Florian Westphal , Netfilter Devel Subject: Re: [PATCH nft 2/2] segtree: fix decomposition of unclosed intervals containing address prefixes Message-ID: <20220921202659.GA30050@breakpoint.cc> References: <20220918172212.3681553-1-jeremy@azazel.net> <20220918172212.3681553-3-jeremy@azazel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Jeremy Sowden wrote: > > __interceptor_malloc libsanitizer/asan/asan_malloc_linux.cpp:145 > > xmalloc src/utils.c:36 > > xzalloc src/utils.c:75 > > expr_alloc src/expression.c:46 > > constant_expr_alloc src/expression.c:420 > > interval_map_decompose src/segtree.c:619 > > I did try running the new shell test under valgrind: lots of noise, not > a lot of signal. :) Yes. You can use -fsanitize=leak as alternative, that has a much better signal/noise ratio. > > Before, 'i' was assigned to the compund expr, but thats no longer the > > case. > > > Does this look good to you? > > Yes, LTGM. Applied, thanks!