From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
Florian Westphal <fwestpha@redhat.com>,
netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] nft: Fix meta statement parsing
Date: Wed, 28 Sep 2022 23:27:09 +0200 [thread overview]
Message-ID: <20220928212709.GO12777@breakpoint.cc> (raw)
In-Reply-To: <YzSM/KSLYpHFzTIN@orbyte.nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> On Wed, Sep 28, 2022 at 07:57:23PM +0200, Florian Westphal wrote:
> > Phil Sutter <phil@nwl.cc> wrote:
> > > The function nft_meta_set_to_target() would always bail since nothing
> > > sets 'sreg->meta_sreg.set' to true. This is obvious, as the immediate
> > > expression "filling" the source register does not indicate its purpose.
> >
> > Hmm, is there a missing test case? I did not see any failures.
>
> extensions/libxt_TRACE.t was failing if I called iptables-test.py with
> '-n' option.
Argh, I only tested classic :-(
> > Yes; from iptables perspective a 'meta set' operation has to be mapped
> > to a target, so there is no need to store this for subsequent
> > consumption.
>
> OK, cool. I'll push this all upstream now. :)
Thanks!
next prev parent reply other threads:[~2022-09-28 21:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 16:23 [iptables PATCH] nft: Fix meta statement parsing Phil Sutter
2022-09-28 17:57 ` Florian Westphal
2022-09-28 18:05 ` Phil Sutter
2022-09-28 21:27 ` Florian Westphal [this message]
2022-09-28 21:39 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928212709.GO12777@breakpoint.cc \
--to=fw@strlen.de \
--cc=fwestpha@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).