From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: Florian Westphal <fw@strlen.de>
Subject: [PATCH nft 0/3] vlan followup fixes
Date: Thu, 29 Sep 2022 15:01:10 +0200 [thread overview]
Message-ID: <20220929130113.22289-1-fw@strlen.de> (raw)
vlan header matching in ip/ip6/inet families may not work, because
default behaviour is to remove the vlan header/tag information.
Update documentation to mention this.
Furthermore, dependency generation was broken so that even if the
vlan striping is disabled matching did not work, as the offset was
not computed correctly.
Add test cases for this too.
Florian Westphal (3):
doc: mention vlan matching in ip/ip6/inet families
evaluate: add ethernet header size offset for implicit vlan dependency
tests: py: add vlan test case for ip/inet family
doc/payload-expression.txt | 8 +++++++
src/evaluate.c | 20 ++++++++++++++++-
tests/py/inet/ether.t | 6 ++++++
tests/py/inet/ether.t.json | 32 ++++++++++++++++++++++++++++
tests/py/inet/ether.t.payload | 20 +++++++++++++++++
tests/py/inet/ether.t.payload.bridge | 16 ++++++++++++++
tests/py/inet/ether.t.payload.ip | 20 +++++++++++++++++
7 files changed, 121 insertions(+), 1 deletion(-)
--
2.35.1
next reply other threads:[~2022-09-29 13:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 13:01 Florian Westphal [this message]
2022-09-29 13:01 ` [PATCH nft 1/3] doc: mention vlan matching in ip/ip6/inet families Florian Westphal
2022-09-29 13:01 ` [PATCH nft 2/3] evaluate: add ethernet header size offset for implicit vlan dependency Florian Westphal
2022-09-29 13:01 ` [PATCH nft 3/3] tests: py: add vlan test case for ip/inet family Florian Westphal
2022-09-30 13:09 ` [PATCH nft 0/3] vlan followup fixes Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929130113.22289-1-fw@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).