From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 2/2] payload: do not kill dependency for proto_unknown
Date: Mon, 31 Oct 2022 12:33:25 +0100 [thread overview]
Message-ID: <20221031113325.GD5040@breakpoint.cc> (raw)
In-Reply-To: <20221031111616.96702-2-pablo@netfilter.org>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> Unsupported meta match on layer 4 protocol sets on protocol context to
> proto_unknown, handle anything coming after it as a raw expression in
> payload_expr_expand().
>
> Moreover, payload_dependency_kill() skips dependency removal if protocol
> is unknown, so raw payload expression leaves meta layer 4 protocol
> remains in place.
>
> Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1641
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
> src/payload.c | 6 ++++--
> tests/py/any/rawpayload.t | 2 ++
> tests/py/any/rawpayload.t.json | 31 +++++++++++++++++++++++++++++++
> tests/py/any/rawpayload.t.payload | 8 ++++++++
LGTM, thanks for including testcases!
prev parent reply other threads:[~2022-10-31 11:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 11:16 [PATCH nft 1/2] netlink_delinearize: complete payload expression in payload statement Pablo Neira Ayuso
2022-10-31 11:16 ` [PATCH nft 2/2] payload: do not kill dependency for proto_unknown Pablo Neira Ayuso
2022-10-31 11:33 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221031113325.GD5040@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).