From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73D21C433FE for ; Thu, 3 Nov 2022 11:04:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230205AbiKCLEF (ORCPT ); Thu, 3 Nov 2022 07:04:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230094AbiKCLEE (ORCPT ); Thu, 3 Nov 2022 07:04:04 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 389A76168; Thu, 3 Nov 2022 04:04:03 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1oqY0b-0001id-DU; Thu, 03 Nov 2022 12:03:41 +0100 Date: Thu, 3 Nov 2022 12:03:41 +0100 From: Florian Westphal To: Ziyang Xuan Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: nfnetlink: fix potential dead lock in nfnetlink_rcv_msg() Message-ID: <20221103110341.GA29268@breakpoint.cc> References: <20221103011202.2160107-1-william.xuanziyang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221103011202.2160107-1-william.xuanziyang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Ziyang Xuan wrote: > When type is NFNL_CB_MUTEX and -EAGAIN error occur in nfnetlink_rcv_msg(), > it does not execute nfnl_unlock(). That would trigger potential dead lock. > > Fixes: 50f2db9e368f ("netfilter: nfnetlink: consolidate callback types") Applied to nf:testing, thanks.