From: Jeremy Sowden <jeremy@azazel.net>
To: Netfilter Devel <netfilter-devel@vger.kernel.org>
Subject: [PATCH ulogd2] doc: mysql: declare MAC protocol columns unsigned
Date: Sat, 5 Nov 2022 16:54:02 +0000 [thread overview]
Message-ID: <20221105165403.2355665-1-jeremy@azazel.net> (raw)
By default, MySQL smallints are signed. This causes problems inserting packets
for ethertypes above 0x7fff, such as IPv6 (0x86dd):
MariaDB [ulogd]> SELECT INSERT_PACKET_FULL(...,'f4:7b:09:41:7a:71','f0:2f:74:4e:b2:f3',34525,0,NULL,NULL,NULL);
^^^^^
which fails as follows:
ERROR 1264 (22003): Out of range value for column 'mac_protocol' at row 1
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
---
doc/mysql-ulogd2-flat.sql | 2 +-
doc/mysql-ulogd2.sql | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/doc/mysql-ulogd2-flat.sql b/doc/mysql-ulogd2-flat.sql
index d71608c65f7f..6d663f6e035d 100644
--- a/doc/mysql-ulogd2-flat.sql
+++ b/doc/mysql-ulogd2-flat.sql
@@ -51,7 +51,7 @@ CREATE TABLE `ulog2` (
`raw_label` tinyint(3) unsigned default NULL,
`mac_saddr_str` varchar(32) default NULL,
`mac_daddr_str` varchar(32) default NULL,
- `oob_protocol` smallint(5) default NULL,
+ `oob_protocol` smallint(5) unsigned default NULL,
`raw_type` int(10) unsigned default NULL,
`mac_str` varchar(255) default NULL,
`tcp_sport` int(5) unsigned default NULL,
diff --git a/doc/mysql-ulogd2.sql b/doc/mysql-ulogd2.sql
index c44f9a9db1e4..782f3689dc0b 100644
--- a/doc/mysql-ulogd2.sql
+++ b/doc/mysql-ulogd2.sql
@@ -84,7 +84,7 @@ CREATE TABLE `mac` (
`_mac_id` bigint unsigned NOT NULL auto_increment,
`mac_saddr` varchar(32) default NULL,
`mac_daddr` varchar(32) default NULL,
- `mac_protocol` smallint(5) default NULL,
+ `mac_protocol` smallint(5) unsigned default NULL,
UNIQUE KEY `key_id` (`_mac_id`)
) ENGINE=INNODB;
@@ -681,7 +681,7 @@ delimiter $$
CREATE FUNCTION INSERT_OR_SELECT_MAC(
`_saddr` varchar(32),
`_daddr` varchar(32),
- `_protocol` smallint(5)
+ `_protocol` smallint(5) unsigned
) RETURNS bigint unsigned
NOT DETERMINISTIC
READS SQL DATA
@@ -764,7 +764,7 @@ CREATE FUNCTION INSERT_PACKET_FULL(
raw_header varchar(256),
mac_saddr varchar(32),
mac_daddr varchar(32),
- mac_protocol smallint(5),
+ mac_protocol smallint(5) unsigned,
_label tinyint(4) unsigned,
sctp_sport smallint(5) unsigned,
sctp_dport smallint(5) unsigned,
--
2.35.1
next reply other threads:[~2022-11-05 16:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 16:54 Jeremy Sowden [this message]
2022-11-09 15:08 ` [PATCH ulogd2] doc: mysql: declare MAC protocol columns unsigned Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221105165403.2355665-1-jeremy@azazel.net \
--to=jeremy@azazel.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).