From: Jakub Kicinski <kuba@kernel.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com
Subject: Re: [PATCH net-next 6/6] netfilter: conntrack: use siphash_4u64
Date: Mon, 14 Nov 2022 19:02:38 -0800 [thread overview]
Message-ID: <20221114190238.693af399@kernel.org> (raw)
In-Reply-To: <20221114104106.8719-7-pablo@netfilter.org>
On Mon, 14 Nov 2022 11:41:06 +0100 Pablo Neira Ayuso wrote:
> From: Florian Westphal <fw@strlen.de>
>
> This function is used for every packet, siphash_4u64 is noticeably faster
> than using local buffer + siphash:
>
> Before:
> 1.23% kpktgend_0 [kernel.vmlinux] [k] __siphash_unaligned
> 0.14% kpktgend_0 [nf_conntrack] [k] hash_conntrack_raw
> After:
> 0.79% kpktgend_0 [kernel.vmlinux] [k] siphash_4u64
> 0.15% kpktgend_0 [nf_conntrack] [k] hash_conntrack_raw
>
> In the pktgen test this gives about ~2.4% performance improvement.
Hi, Mr Nit Pick here, can we silence the spatse warnings?
net/netfilter/nf_conntrack_core.c:222:14: warning: cast from restricted __be16
net/netfilter/nf_conntrack_core.c:222:55: warning: restricted __be16 degrades to integer
next prev parent reply other threads:[~2022-11-15 3:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 10:41 [PATCH net-next 0/6] Netfilter updates for net-next Pablo Neira Ayuso
2022-11-14 10:41 ` [PATCH net-next 1/6] netfilter: nft_payload: use __be16 to store gre version Pablo Neira Ayuso
2022-11-14 10:41 ` [PATCH net-next 2/6] netfilter: nft_inner: fix return value check in nft_inner_parse_l2l3() Pablo Neira Ayuso
2022-11-14 10:41 ` [PATCH net-next 3/6] netfilter: nf_tables: Extend nft_expr_ops::dump callback parameters Pablo Neira Ayuso
2022-11-15 3:04 ` Jakub Kicinski
2022-11-15 9:40 ` Pablo Neira Ayuso
2022-11-14 10:41 ` [PATCH net-next 4/6] netfilter: nf_tables: Introduce NFT_MSG_GETRULE_RESET Pablo Neira Ayuso
2022-11-14 10:41 ` [PATCH net-next 5/6] netfilter: rpfilter/fib: clean up some inconsistent indenting Pablo Neira Ayuso
2022-11-14 10:41 ` [PATCH net-next 6/6] netfilter: conntrack: use siphash_4u64 Pablo Neira Ayuso
2022-11-15 3:02 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-11-15 9:59 [PATCH net-next,v2 0/6] Netfilter updates for net-next Pablo Neira Ayuso
2022-11-15 9:59 ` [PATCH net-next 6/6] netfilter: conntrack: use siphash_4u64 Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221114190238.693af399@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).