From: Phil Sutter <phil@nwl.cc>
To: netfilter-devel@vger.kernel.org
Subject: [iptables PATCH 00/13] Extensions: Review xlate callbacks
Date: Wed, 23 Nov 2022 17:43:37 +0100 [thread overview]
Message-ID: <20221123164350.10502-1-phil@nwl.cc> (raw)
This is a review of all extensions' xlate callbacks focussing on
correctness of operation and return code.
Patches 1 and 2 address ebtables mark target.
Patches 3, 4, 6 and 9 add 'return 0' calls in more or less unlikely
cases.
Patch 5 fixes multiple problems in CONNMARK target.
Patches 7, 8 and 10 extend some translations.
The last three patches add comments to help future reviewers asserting
code correctness.
Phil Sutter (13):
extensions: libebt_mark: Fix mark target xlate
extensions: libebt_mark: Fix xlate test case
extensions: libebt_redirect: Fix xlate return code
extensions: libipt_ttl: Sanitize xlate callback
extensions: CONNMARK: Fix xlate callback
extensions: MARK: Sanitize MARK_xlate()
extensions: TCPMSS: Use xlate callback for IPv6, too
extensions: TOS: Fix v1 xlate callback
extensions: ecn: Sanitize xlate callback
extensions: tcp: Translate TCP option match
extensions: libebt_log: Add comment to clarify xlate callback
extensions: frag: Add comment to clarify xlate callback
extensions: ipcomp: Add comment to clarify xlate callback
extensions/libebt_log.c | 2 ++
extensions/libebt_mark.c | 2 +-
extensions/libebt_mark.txlate | 11 +++++++++++
extensions/libebt_mark.xlate | 11 -----------
extensions/libebt_redirect.c | 2 +-
extensions/libip6t_frag.c | 2 ++
extensions/libipt_ttl.c | 4 ++--
extensions/libxt_CONNMARK.c | 15 ++++++++++-----
extensions/libxt_CONNMARK.txlate | 3 +++
extensions/libxt_MARK.c | 2 ++
extensions/libxt_TCPMSS.c | 1 +
extensions/libxt_TOS.c | 33 ++++++++++++++++++++++----------
extensions/libxt_TOS.txlate | 9 ++++++---
extensions/libxt_ecn.c | 2 ++
extensions/libxt_ipcomp.c | 2 ++
extensions/libxt_ipcomp.c.man | 3 ---
extensions/libxt_tcp.c | 9 ++++++---
extensions/libxt_tcp.txlate | 6 ++++++
18 files changed, 80 insertions(+), 39 deletions(-)
create mode 100644 extensions/libebt_mark.txlate
delete mode 100644 extensions/libebt_mark.xlate
--
2.38.0
next reply other threads:[~2022-11-23 16:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 16:43 Phil Sutter [this message]
2022-11-23 16:43 ` [iptables PATCH 01/13] extensions: libebt_mark: Fix mark target xlate Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 02/13] extensions: libebt_mark: Fix xlate test case Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 03/13] extensions: libebt_redirect: Fix xlate return code Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 04/13] extensions: libipt_ttl: Sanitize xlate callback Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 05/13] extensions: CONNMARK: Fix " Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 06/13] extensions: MARK: Sanitize MARK_xlate() Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 07/13] extensions: TCPMSS: Use xlate callback for IPv6, too Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 08/13] extensions: TOS: Fix v1 xlate callback Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 09/13] extensions: ecn: Sanitize " Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 10/13] extensions: tcp: Translate TCP option match Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 11/13] extensions: libebt_log: Add comment to clarify xlate callback Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 12/13] extensions: frag: " Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 13/13] extensions: ipcomp: " Phil Sutter
2022-11-23 21:26 ` [iptables PATCH 00/13] Extensions: Review xlate callbacks Florian Westphal
2022-11-24 9:24 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123164350.10502-1-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).