From: Phil Sutter <phil@nwl.cc>
To: netfilter-devel@vger.kernel.org
Subject: [iptables PATCH 06/13] extensions: MARK: Sanitize MARK_xlate()
Date: Wed, 23 Nov 2022 17:43:43 +0100 [thread overview]
Message-ID: <20221123164350.10502-7-phil@nwl.cc> (raw)
In-Reply-To: <20221123164350.10502-1-phil@nwl.cc>
Since markinfo->mode might contain unexpected values, add a default case
returning zero.
Fixes: afefc7a134ca0 ("extensions: libxt_MARK: Add translation for revision 1 to nft")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
extensions/libxt_MARK.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/extensions/libxt_MARK.c b/extensions/libxt_MARK.c
index 1536563d0f4c7..100f6a38996ac 100644
--- a/extensions/libxt_MARK.c
+++ b/extensions/libxt_MARK.c
@@ -366,6 +366,8 @@ static int MARK_xlate(struct xt_xlate *xl,
case XT_MARK_OR:
xt_xlate_add(xl, "mark or 0x%x ", (uint32_t)markinfo->mark);
break;
+ default:
+ return 0;
}
return 1;
--
2.38.0
next prev parent reply other threads:[~2022-11-23 16:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 16:43 [iptables PATCH 00/13] Extensions: Review xlate callbacks Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 01/13] extensions: libebt_mark: Fix mark target xlate Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 02/13] extensions: libebt_mark: Fix xlate test case Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 03/13] extensions: libebt_redirect: Fix xlate return code Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 04/13] extensions: libipt_ttl: Sanitize xlate callback Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 05/13] extensions: CONNMARK: Fix " Phil Sutter
2022-11-23 16:43 ` Phil Sutter [this message]
2022-11-23 16:43 ` [iptables PATCH 07/13] extensions: TCPMSS: Use xlate callback for IPv6, too Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 08/13] extensions: TOS: Fix v1 xlate callback Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 09/13] extensions: ecn: Sanitize " Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 10/13] extensions: tcp: Translate TCP option match Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 11/13] extensions: libebt_log: Add comment to clarify xlate callback Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 12/13] extensions: frag: " Phil Sutter
2022-11-23 16:43 ` [iptables PATCH 13/13] extensions: ipcomp: " Phil Sutter
2022-11-23 21:26 ` [iptables PATCH 00/13] Extensions: Review xlate callbacks Florian Westphal
2022-11-24 9:24 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123164350.10502-7-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).