From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BD88C433FE for ; Wed, 23 Nov 2022 21:26:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235701AbiKWV00 (ORCPT ); Wed, 23 Nov 2022 16:26:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235147AbiKWV0Z (ORCPT ); Wed, 23 Nov 2022 16:26:25 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD89C7660 for ; Wed, 23 Nov 2022 13:26:24 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1oxxG9-00044E-Rj; Wed, 23 Nov 2022 22:26:21 +0100 Date: Wed, 23 Nov 2022 22:26:21 +0100 From: Florian Westphal To: Phil Sutter Cc: netfilter-devel@vger.kernel.org Subject: Re: [iptables PATCH 00/13] Extensions: Review xlate callbacks Message-ID: <20221123212621.GD2753@breakpoint.cc> References: <20221123164350.10502-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221123164350.10502-1-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Phil Sutter wrote: > This is a review of all extensions' xlate callbacks focussing on > correctness of operation and return code. Thanks, please push this out.