From: Alex Forster <aforster@cloudflare.com>
To: netfilter-devel@vger.kernel.org
Cc: Alex Forster <aforster@cloudflare.com>, Florian Westphal <fw@strlen.de>
Subject: [PATCH] json: fix 'add flowtable' command
Date: Thu, 1 Dec 2022 21:35:01 -0600 [thread overview]
Message-ID: <20221202033501.48129-1-aforster@cloudflare.com> (raw)
In `json_parse_cmd_add_flowtable`, the format arguments passed to `json_unpack` are incorrect: the object key name ("dev") is not provided.
Fixes: 586ad2103 ("parser_json: permit empty device list")
Signed-off-by: Alex Forster <aforster@cloudflare.com>
Cc: Florian Westphal <fw@strlen.de>
---
src/parser_json.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/parser_json.c b/src/parser_json.c
index 76c268f8..aa00e9ec 100644
--- a/src/parser_json.c
+++ b/src/parser_json.c
@@ -3253,7 +3253,7 @@ static struct cmd *json_parse_cmd_add_flowtable(struct json_ctx *ctx,
return NULL;
}
- json_unpack(root, "{s:o}", &devs);
+ json_unpack(root, "{s:o}", "dev", &devs);
hookstr = chain_hookname_lookup(hook);
if (!hookstr) {
--
2.38.1
next reply other threads:[~2022-12-02 3:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 3:35 Alex Forster [this message]
2022-12-02 12:54 ` [PATCH] json: fix 'add flowtable' command Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221202033501.48129-1-aforster@cloudflare.com \
--to=aforster@cloudflare.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).