From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1339BC4332F for ; Mon, 12 Dec 2022 16:45:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232844AbiLLQpM (ORCPT ); Mon, 12 Dec 2022 11:45:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232533AbiLLQoi (ORCPT ); Mon, 12 Dec 2022 11:44:38 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA75114D15 for ; Mon, 12 Dec 2022 08:42:26 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1p4lsn-0002xS-1s; Mon, 12 Dec 2022 17:42:25 +0100 Date: Mon, 12 Dec 2022 17:42:25 +0100 From: Florian Westphal To: Pablo Neira Ayuso Cc: Florian Westphal , netfilter-devel Subject: Re: [PATCH nft 0/3] fix map update with concatenation and timeouts Message-ID: <20221212164225.GB3457@breakpoint.cc> References: <20221212100436.84116-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Pablo Neira Ayuso wrote: > On Mon, Dec 12, 2022 at 11:04:33AM +0100, Florian Westphal wrote: > > When "update" is used with a map, nft will ignore a given timeout. > > Futhermore, listing is broken, only the first data expression > > gets decoded: > > > > in: > > meta l4proto tcp update @pinned { ip saddr . ct original proto-src : ip daddr . ct original proto-dst timeout 90s } > > out: > > meta l4proto tcp update @pinned { ip saddr . ct original proto-src : ip daddr } > > > > Missing timeout is input bug (never passed to kernel), mussing > > "proto-dst" is output bug. > > > > Also add a test case. > > Series LGTM, thanks. > > I might follow up to restrict the timeout to the key side unless you > would like to look into this. I've pushed this series out; I fixed the typo in patch 1 and I mangled patch 2 to reject data-element timeouts from the eval phase.