From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jeremy Sowden <jeremy@azazel.net>,
Netfilter Devel <netfilter-devel@vger.kernel.org>
Subject: Re: [libnetfilter_conntrack PATCH] conntrack: increase the length of `l4proto_map`
Date: Wed, 11 Jan 2023 19:08:18 +0100 [thread overview]
Message-ID: <20230111180818.GD27644@breakpoint.cc> (raw)
In-Reply-To: <Y7758rNEafF9XurG@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Fri, Dec 23, 2022 at 12:38:06PM +0000, Jeremy Sowden wrote:
> > With addition of MPTCP `IPPROTO_MAX` is greater than 256, so extend the
> > array to account for the new upper bound.
>
> Applied, thanks.
>
> I don't expect we will ever see IPPROTO_MPTCP in this path though.
> To my understanding, this definition is targeted at the
> setsockopt/getsockopt() use-case. IP headers and the ctnetlink
> interface also assumes 8-bits protocol numbers.
Yes, this is an uapi thing:
socket(AF_INET, SOCK_STREAM, IPPROTO_TCP); vs.
socket(AF_INET, SOCK_STREAM, IPPROTO_MPTCP);
Only second version results in a multipath-tcp aware socket.
If mptcp is active (both peers need to support it), tcp frames will
have an 'mptcp' option, but its still tcp (6) on wire.
next prev parent reply other threads:[~2023-01-11 18:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 12:38 [libnetfilter_conntrack PATCH] conntrack: increase the length of `l4proto_map` Jeremy Sowden
2023-01-11 18:03 ` Pablo Neira Ayuso
2023-01-11 18:08 ` Florian Westphal [this message]
2023-01-11 18:21 ` Pablo Neira Ayuso
2023-01-11 18:34 ` Jeremy Sowden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230111180818.GD27644@breakpoint.cc \
--to=fw@strlen.de \
--cc=jeremy@azazel.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).