From: Florian Westphal <fw@strlen.de>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Florian Westphal <fw@strlen.de>,
Igor Artemiev <Igor.A.Artemiev@mcst.ru>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [lvc-project] [PATCH] netfilter: xt_recent: Fix attempt to update removed entry
Date: Thu, 9 Feb 2023 21:17:12 +0100 [thread overview]
Message-ID: <20230209201712.GB17303@breakpoint.cc> (raw)
In-Reply-To: <6152n4q7-1ssr-521p-786s-71q4q9731370@vanv.qr>
Jan Engelhardt <jengelh@inai.de> wrote:
> On Thursday 2023-02-09 16:07, Florian Westphal wrote:
>
> >Igor Artemiev <Igor.A.Artemiev@mcst.ru> wrote:
> >> When both --remove and --update flag are specified, there's a code
> >> path at which the entry to be updated is removed beforehand,
> >> that leads to kernel crash. Update entry, if --remove flag
> >> don't specified.
> >>
> >> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> >How did you manage to do this? --update and --remove are supposed
> >to be mutually exclusive.
>
> I suppose the exclusivity is only checked at the iptables command-line
> and neverwhere else.
Removing the userspace check gives me an -EINVAL from checkentry.
prev parent reply other threads:[~2023-02-09 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 12:58 [lvc-project] [PATCH] netfilter: xt_recent: Fix attempt to update removed entry Igor Artemiev
2023-02-09 15:07 ` Florian Westphal
2023-02-09 16:09 ` Jan Engelhardt
2023-02-09 20:17 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230209201712.GB17303@breakpoint.cc \
--to=fw@strlen.de \
--cc=Igor.A.Artemiev@mcst.ru \
--cc=coreteam@netfilter.org \
--cc=jengelh@inai.de \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).