Linux Netfilter development
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Jozsef Kadlecsik <kadlec@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: [ipset PATCH 2/2] xlate: Drop dead code
Date: Wed, 22 Feb 2023 18:02:41 +0100	[thread overview]
Message-ID: <20230222170241.26208-3-phil@nwl.cc> (raw)
In-Reply-To: <20230222170241.26208-1-phil@nwl.cc>

Set type is not needed when manipulating elements, the assigned
variable was unused in that case.

Fixes: 325af556cd3a6 ("add ipset to nftables translation infrastructure")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 lib/ipset.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lib/ipset.c b/lib/ipset.c
index 2e098e435d954..8e63af56d2a51 100644
--- a/lib/ipset.c
+++ b/lib/ipset.c
@@ -1876,9 +1876,6 @@ static int ipset_xlate(struct ipset *ipset, enum ipset_cmd cmd,
 				cmd == IPSET_CMD_DEL ? "delete" : "get",
 		       ipset_xlate_family(family), table, set);
 
-		typename = ipset_data_get(data, IPSET_OPT_TYPENAME);
-		type = ipset_xlate_set_type(typename);
-
 		xlate_set = (struct ipset_xlate_set *)
 				ipset_xlate_set_get(ipset, set);
 		if (xlate_set && xlate_set->interval)
-- 
2.38.0


  parent reply	other threads:[~2023-02-22 17:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-22 17:02 [ipset PATCH 0/2] Two minor code fixes Phil Sutter
2023-02-22 17:02 ` [ipset PATCH 1/2] xlate: Fix for fd leak in error path Phil Sutter
2023-02-22 17:02 ` Phil Sutter [this message]
2023-03-01 22:28 ` [ipset PATCH 0/2] Two minor code fixes Pablo Neira Ayuso
2023-03-02  9:04   ` Phil Sutter
2023-03-10 11:56     ` Pablo Neira Ayuso
2023-03-10 12:05       ` Phil Sutter
2023-03-10 12:22         ` Pablo Neira Ayuso
2023-03-10 12:37           ` Phil Sutter
2023-03-10 13:05             ` Pablo Neira Ayuso
2023-03-10 12:18 ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230222170241.26208-3-phil@nwl.cc \
    --to=phil@nwl.cc \
    --cc=kadlec@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox