From: eric_sage@apple.com
To: netfilter-devel@vger.kernel.org
Cc: fw@strlen.de, kadlec@netfilter.org, pablo@netfilter.org,
Eric Sage <eric_sage@apple.com>
Subject: [PATCH] netfilter: nfnetlink_queue: enable classid socket info retrieval
Date: Wed, 22 Mar 2023 18:33:29 -0400 [thread overview]
Message-ID: <20230322223329.48949-1-eric_sage@apple.com> (raw)
From: Eric Sage <eric_sage@apple.com>
This enables associating a socket with a v1 net_cls cgroup. Useful for
applying a per-cgroup policy when processing packets in userspace.
Signed-off-by: Eric Sage <eric_sage@apple.com>
---
.../uapi/linux/netfilter/nfnetlink_queue.h | 4 ++-
net/netfilter/nfnetlink_queue.c | 27 +++++++++++++++++++
2 files changed, 30 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/netfilter/nfnetlink_queue.h b/include/uapi/linux/netfilter/nfnetlink_queue.h
index ef7c97f21a15..9fbc8c49bd6d 100644
--- a/include/uapi/linux/netfilter/nfnetlink_queue.h
+++ b/include/uapi/linux/netfilter/nfnetlink_queue.h
@@ -62,6 +62,7 @@ enum nfqnl_attr_type {
NFQA_VLAN, /* nested attribute: packet vlan info */
NFQA_L2HDR, /* full L2 header */
NFQA_PRIORITY, /* skb->priority */
+ NFQA_CLASSID, /* __u32 cgroup classid */
__NFQA_MAX
};
@@ -116,7 +117,8 @@ enum nfqnl_attr_config {
#define NFQA_CFG_F_GSO (1 << 2)
#define NFQA_CFG_F_UID_GID (1 << 3)
#define NFQA_CFG_F_SECCTX (1 << 4)
-#define NFQA_CFG_F_MAX (1 << 5)
+#define NFQA_CFG_F_CLASSID (1 << 5)
+#define NFQA_CFG_F_MAX (1 << 6)
/* flags for NFQA_SKB_INFO */
/* packet appears to have wrong checksums, but they are ok */
diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c
index 87a9009d5234..8c513a2e0e30 100644
--- a/net/netfilter/nfnetlink_queue.c
+++ b/net/netfilter/nfnetlink_queue.c
@@ -301,6 +301,25 @@ static int nfqnl_put_sk_uidgid(struct sk_buff *skb, struct sock *sk)
return -1;
}
+static int nfqnl_put_sk_classid(struct sk_buff *skb, struct sock *sk)
+{
+ u32 classid;
+
+ if (!sk_fullsock(sk))
+ return 0;
+
+ read_lock_bh(sk->sk_callback_lock);
+ sock_cgroup_classid(&entskb->sk->sk_cgrp_data);
+ if (nla_put_be32(skb, NFQA_CLASSID, htonl(classid)))
+ goto nla_put_failure;
+ read_unlock_bh(sk->sk_callback_lock);
+ return 0;
+
+nla_put_failure:
+ read_unlock_bh(sk->sk_callback_lock);
+ return -1;
+}
+
static u32 nfqnl_get_sk_secctx(struct sk_buff *skb, char **secdata)
{
u32 seclen = 0;
@@ -461,6 +480,10 @@ nfqnl_build_packet_message(struct net *net, struct nfqnl_instance *queue,
+ nla_total_size(sizeof(u_int32_t))); /* gid */
}
+ if (queue->flags & NFQA_CFG_F_CLASSID) {
+ size += nla_total_size(sizeof(u_int32_t)); /* classid */
+ }
+
if ((queue->flags & NFQA_CFG_F_SECCTX) && entskb->sk) {
seclen = nfqnl_get_sk_secctx(entskb, &secdata);
if (seclen)
@@ -599,6 +622,10 @@ nfqnl_build_packet_message(struct net *net, struct nfqnl_instance *queue,
nfqnl_put_sk_uidgid(skb, entskb->sk) < 0)
goto nla_put_failure;
+ if ((queue->flags & NFQA_CFG_F_CLASSID) && entskb->sk &&
+ nfqnl_put_sk_classid(skb, entskb->sk) < 0)
+ goto nla_put_failure;
+
if (seclen && nla_put(skb, NFQA_SECCTX, seclen, secdata))
goto nla_put_failure;
--
2.37.1
next reply other threads:[~2023-03-22 23:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 22:33 eric_sage [this message]
2023-03-23 0:00 ` [PATCH] netfilter: nfnetlink_queue: enable classid socket info retrieval Florian Westphal
2023-03-23 4:10 ` kernel test robot
2023-03-23 4:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322223329.48949-1-eric_sage@apple.com \
--to=eric_sage@apple.com \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).