From: Stefano Brivio <sbrivio@redhat.com>
To: Phil Sutter <phil@nwl.cc>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] tests: shell: Fix for unstable sets/0043concatenated_ranges_0
Date: Thu, 20 Apr 2023 18:35:54 +0200 [thread overview]
Message-ID: <20230420183554.4af78bbd@elisabeth> (raw)
In-Reply-To: <20230420154723.27089-1-phil@nwl.cc>
On Thu, 20 Apr 2023 17:47:23 +0200
Phil Sutter <phil@nwl.cc> wrote:
> On my (slow?) testing VM, The test tends to fail when doing a full run
> (i.e., calling run-test.sh without arguments) and tends to pass when run
> individually.
>
> The problem seems to be the 1s element timeout which in some cases may
> pass before element deletion occurs.
Whoops. Yes I think so too.
> Simply fix this by doubling the
> timeout. It has to pass just once, so shouldn't hurt too much.
>
> Fixes: 618393c6b3f25 ("tests: Introduce test for set with concatenated ranges")
> Cc: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
next prev parent reply other threads:[~2023-04-20 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 15:47 [nft PATCH] tests: shell: Fix for unstable sets/0043concatenated_ranges_0 Phil Sutter
2023-04-20 16:35 ` Stefano Brivio [this message]
2023-04-20 16:59 ` Pablo Neira Ayuso
2023-04-20 21:15 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420183554.4af78bbd@elisabeth \
--to=sbrivio@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox