From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netfilter-devel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 2D947C77B73
	for <netfilter-devel@archiver.kernel.org>; Fri, 21 Apr 2023 03:25:57 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230096AbjDUDZy (ORCPT
        <rfc822;netfilter-devel@archiver.kernel.org>);
        Thu, 20 Apr 2023 23:25:54 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38880 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230038AbjDUDZx (ORCPT
        <rfc822;netfilter-devel@vger.kernel.org>);
        Thu, 20 Apr 2023 23:25:53 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB69F10E3;
        Thu, 20 Apr 2023 20:25:52 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 44D8860ACF;
        Fri, 21 Apr 2023 03:25:52 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54A51C4339B;
        Fri, 21 Apr 2023 03:25:51 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1682047551;
        bh=YDu3KLe7lykirea3rL8THfo3mJjSppTvOkZadvSlh1k=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=VhySG3GQ7RyWXIa6FWJOGd51C/GQb6U1cMQUTbWrRe5ZWvCxVaCB/dqLNjUVl9HXr
         EgOZyZTibq/itlMJ6rWU6Z+sofVuC4tx3XMzgK9u9dihH/N9GQ3DQy1vKMZttQqZje
         nt/YhDjgVZfsxZi6ua1Kag7uJB5rTbZEDoL9bmy2SLYh+P8wZ1SNI6MzySCwJm9esv
         +NxN6xGRdH4j4ptd4dqNXvDBK0U2CxwnXfN4wF4bhBtCB4lorv0+rsNLDTAZM8ykv5
         fVax+vNHU/YeazCOZYI0AF7nexbY0/m3If6tIP0EhAk2WRxIloIzncT1xs3QAHkGUG
         LgF30Z4nnNpAw==
Date:   Thu, 20 Apr 2023 20:25:50 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Pablo Neira Ayuso <pablo@netfilter.org>
Cc:     netfilter-devel@vger.kernel.org, davem@davemloft.net,
        netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com
Subject: Re: [PATCH net 0/2] Netfilter fixes for net
Message-ID: <20230420202550.1b466802@kernel.org>
In-Reply-To: <20230420170657.45373-1-pablo@netfilter.org>
References: <20230420170657.45373-1-pablo@netfilter.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netfilter-devel.vger.kernel.org>
X-Mailing-List: netfilter-devel@vger.kernel.org

On Thu, 20 Apr 2023 19:06:55 +0200 Pablo Neira Ayuso wrote:
> 1) Set on IPS_CONFIRMED before change_status() otherwise EBUSY is
>    bogusly hit. This bug was introduced in the 6.3 release cycle.
> 
> 2) Fix nfnetlink_queue conntrack support: Set/dump timeout
>    accordingly for unconfirmed conntrack entries. Make sure this
>    is done after IPS_CONFIRMED is set on. This is an old bug, it
>    happens since the introduction of this feature.

It missed our PR anyway so please resend with a signed tag.