From: Phil Sutter <phil@nwl.cc>
To: netfilter-devel@vger.kernel.org
Cc: Florian Westphal <fw@strlen.de>,
Pablo Neira Ayuso <pablo@netfilter.org>, Eric Garver <e@erig.me>,
danw@redhat.com, aauren@gmail.com
Subject: [iptables PATCH 0/4] Implement a best-effort forward compat solution
Date: Fri, 5 May 2023 20:34:42 +0200 [thread overview]
Message-ID: <20230505183446.28822-1-phil@nwl.cc> (raw)
Instead of adding a second, compatible rule-representation to kernel for
consumption by older user space, follow a much simpler route by
implementing a compat-mode into current *tables-nft which avoids any of
the later internal changes which may prevent an old iptables-nft from
parsing a kernel's rule correctly.
Patch 1 is just prep work, patch 2 adds the core logic, patch 3 exposes
it to CLI and patch 4 finally adds some testing.
This should resolve nfbz#1632[1], albeit requiring adjustments in how
users call iptables.
[1] https://bugzilla.netfilter.org/show_bug.cgi?id=1632
Phil Sutter (4):
nft: Pass nft_handle to add_{target,action}()
nft: Introduce and use bool nft_handle::compat
Add --compat option to *tables-nft and *-nft-restore commands
tests: Test compat mode
iptables-test.py | 19 ++++--
iptables/nft-arp.c | 2 +-
iptables/nft-bridge.c | 9 +--
iptables/nft-ipv4.c | 2 +-
iptables/nft-ipv6.c | 2 +-
iptables/nft-shared.c | 2 +-
iptables/nft.c | 15 +++--
iptables/nft.h | 5 +-
.../testcases/nft-only/0011-compat-mode_0 | 61 +++++++++++++++++++
iptables/xshared.c | 7 ++-
iptables/xshared.h | 1 +
iptables/xtables-arp.c | 1 +
iptables/xtables-eb.c | 7 ++-
iptables/xtables-restore.c | 17 +++++-
iptables/xtables.c | 2 +
15 files changed, 129 insertions(+), 23 deletions(-)
create mode 100755 iptables/tests/shell/testcases/nft-only/0011-compat-mode_0
--
2.40.0
next reply other threads:[~2023-05-05 18:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 18:34 Phil Sutter [this message]
2023-05-05 18:34 ` [iptables PATCH 1/4] nft: Pass nft_handle to add_{target,action}() Phil Sutter
2023-05-05 18:34 ` [iptables PATCH 2/4] nft: Introduce and use bool nft_handle::compat Phil Sutter
2023-05-05 18:34 ` [iptables PATCH 3/4] Add --compat option to *tables-nft and *-nft-restore commands Phil Sutter
2023-05-31 0:16 ` Pablo Neira Ayuso
2023-05-31 9:02 ` Phil Sutter
2023-05-31 11:28 ` Florian Westphal
2023-05-31 12:10 ` Phil Sutter
2023-06-23 16:52 ` Phil Sutter
2023-05-05 18:34 ` [iptables PATCH 4/4] tests: Test compat mode Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230505183446.28822-1-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=aauren@gmail.com \
--cc=danw@redhat.com \
--cc=e@erig.me \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).