From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA1AAC7EE25 for ; Mon, 12 Jun 2023 08:06:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233433AbjFLIGy (ORCPT ); Mon, 12 Jun 2023 04:06:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233604AbjFLIGi (ORCPT ); Mon, 12 Jun 2023 04:06:38 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0F6110E4 for ; Mon, 12 Jun 2023 01:05:43 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1q8cYX-0004r9-5U; Mon, 12 Jun 2023 10:05:41 +0200 Date: Mon, 12 Jun 2023 10:05:41 +0200 From: Florian Westphal To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH nf 1/6] netfilter: nf_tables: fix chain binding transaction logic Message-ID: <20230612080541.GA2186@breakpoint.cc> References: <20230611212203.1127-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230611212203.1127-1-pablo@netfilter.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Pablo Neira Ayuso wrote: > - > - if (!nft_chain_is_bound(chain)) > - break; > - > - chain->table->use++; > - list_for_each_entry(rule, &chain->rules, list) > - chain->use++; > - Thanks for removing this, I could not find a reason why the use count increment is required.