From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] src: avoid IPPROTO_MAX for array definitions
Date: Wed, 21 Jun 2023 13:18:15 +0200 [thread overview]
Message-ID: <20230621111815.GC24035@breakpoint.cc> (raw)
In-Reply-To: <ZJIpBfHFHYj6PWfx@calendula>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Tue, Jun 20, 2023 at 10:08:36PM +0200, Florian Westphal wrote:
> > ip header can only accomodate 8but value, but IPPROTO_MAX has been bumped
> > due to uapi reasons to support MPTCP (262, which is used to toggle on
> > multipath support in tcp).
>
> Maybe use IPPROTO_RAW + 1, hopefully that won't ever change.
If you don't like UINT8_MAX+1, would you be fine with open-coding, i.e.
[256] ?
next prev parent reply other threads:[~2023-06-21 11:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 20:08 [PATCH nft] src: avoid IPPROTO_MAX for array definitions Florian Westphal
2023-06-20 22:32 ` Pablo Neira Ayuso
2023-06-21 11:18 ` Florian Westphal [this message]
2023-06-21 14:41 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621111815.GC24035@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).