From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <edumazet@google.com>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: conntrack: dccp: copy entire header to stack buffer, not just basic one
Date: Wed, 21 Jun 2023 17:52:22 +0200 [thread overview]
Message-ID: <20230621155222.GF24035@breakpoint.cc> (raw)
In-Reply-To: <CANn89i+RGTkWuOeVwf5ocRuk4+heQcEeZVFcrRKeR4sRKoN1KQ@mail.gmail.com>
Eric Dumazet <edumazet@google.com> wrote:
> > + struct dccp_hdr *dh;
> >
> > dh = skb_header_pointer(skb, dataoff, sizeof(_dh), &_dh);
>
> sizeof(struct dccp_hdr) , or sizeof(_dh._dh) ?
sizeof(*dh) :-)
Thanks, I will send v2.
prev parent reply other threads:[~2023-06-21 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 15:44 [PATCH nf] netfilter: conntrack: dccp: copy entire header to stack buffer, not just basic one Florian Westphal
2023-06-21 15:48 ` Eric Dumazet
2023-06-21 15:52 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621155222.GF24035@breakpoint.cc \
--to=fw@strlen.de \
--cc=edumazet@google.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).