From: Florian Westphal <fw@strlen.de>
To: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
Cc: Simon Horman <simon.horman@corigine.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Patrick McHardy <kaber@trash.net>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>,
"coreteam@netfilter.org" <coreteam@netfilter.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: Re: [PATCH] netfilter: nf_conntrack_sip: fix the ct_sip_parse_numerical_param() return value.
Date: Thu, 22 Jun 2023 16:43:25 +0200 [thread overview]
Message-ID: <20230622144325.GC29784@breakpoint.cc> (raw)
In-Reply-To: <6f2b5c12-82b5-2496-23a3-05ab22d7b14b@infotecs.ru>
Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru> wrote:
> Hi, Simon.
> I'm sorry to bother you.
> Will this patch be applied or rejected?
Please resend, keeping Simons Reviewd-by tag.
Please update the commit message as per your and Simons
conversation, i.e. that the return value is now a tristate,
0 for not found and -1 for 'malformed' and that you checked
all callers that they will do the right thing.
prev parent reply other threads:[~2023-06-22 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 15:04 [PATCH] netfilter: nf_conntrack_sip: fix the ct_sip_parse_numerical_param() return value Gavrilov Ilia
2023-04-28 19:24 ` Simon Horman
2023-05-02 11:43 ` Gavrilov Ilia
2023-05-02 14:05 ` Simon Horman
2023-05-02 14:16 ` Gavrilov Ilia
2023-05-02 15:38 ` Simon Horman
2023-06-22 13:55 ` Gavrilov Ilia
2023-06-22 14:43 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230622144325.GC29784@breakpoint.cc \
--to=fw@strlen.de \
--cc=Ilia.Gavrilov@infotecs.ru \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kaber@trash.net \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).